Skip to content

Fix Benchmark tests, remove a broken one & add two new #15250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Apr 16, 2021
Merged

Fix Benchmark tests, remove a broken one & add two new #15250

merged 23 commits into from
Apr 16, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Apr 2, 2021

as title

techknowlogick
techknowlogick reviewed Apr 2, 2021
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 2, 2021
techknowlogick
techknowlogick reviewed Apr 2, 2021
View reviewed changes
@6543 6543 added type/testing performance/speed performance issues with slow downs labels Apr 2, 2021
@6543 6543 added this to the 1.15.0 milestone Apr 2, 2021
@6543 6543 mentioned this pull request Apr 2, 2021
Closed
techknowlogick
techknowlogick reviewed Apr 2, 2021
View reviewed changes
6543
6543 commented Apr 4, 2021
View reviewed changes
@codecov-io
Copy link

codecov-io commented Apr 4, 2021 •
edited
Loading

Codecov Report

Merging #15250 (e19a0d5) into master (6341130) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15250      +/-   ##
==========================================
+ Coverage   43.83%   43.84%   +0.01%     
==========================================
  Files         677      677              
  Lines       81338    81338              
==========================================
+ Hits        35652    35662      +10     
+ Misses      39909    39901       -8     
+ Partials     5777     5775       -2
Impacted Files Coverage Δ
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️
models/error.go 39.52% <0.00%> (+0.47%) ⬆️
services/pull/pull.go 43.30% <0.00%> (+0.48%) ⬆️
models/repo_list.go 78.43% <0.00%> (+0.78%) ⬆️
modules/queue/workerpool.go 60.00% <0.00%> (+1.22%) ⬆️
modules/queue/unique_queue_disk_channel.go 55.22% <0.00%> (+1.49%) ⬆️
modules/indexer/stats/db.go 56.00% <0.00%> (+8.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6341130...e19a0d5. Read the comment docs.

zeripath
zeripath reviewed Apr 11, 2021
View reviewed changes
6543
6543 commented Apr 12, 2021
View reviewed changes
6543
6543 commented Apr 12, 2021
View reviewed changes
@6543
Copy link
Member Author

6543 commented Apr 12, 2021

@zeripath in the first place just to test if gogit benchmark would behave different ... removed

@6543 6543 changed the title CI: Exec Benchmark tests Fix Benchmark tests, remove a broken one & add two new Apr 12, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 12, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 16, 2021
@6543 6543 merged commit a67861b into go-gitea:master Apr 16, 2021
@6543 6543 deleted the benchmark_tests branch April 16, 2021 18:30
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick left review comments

@lunny lunny lunny approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. performance/speed performance issues with slow downs type/testing
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
6 participants
@6543 @codecov-io @lunny @techknowlogick @zeripath @GiteaBot