Skip to content

response simple text message for not html request when 404 #15229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 1, 2021
Merged

response simple text message for not html request when 404 #15229

merged 3 commits into from
Apr 1, 2021

Conversation

a1012112796
Copy link
Member

@a1012112796 a1012112796 commented Apr 1, 2021 •
edited
Loading

example view:

tmp

@a1012112796
response simple text message for not html request when response 404
3473477 
Signed-off-by: a1012112796 <1012112796@qq.com>
@a1012112796 a1012112796 changed the title response simple text message for not html request when response 404 response simple text message for not html request when 404 Apr 1, 2021
@a1012112796 a1012112796 added the type/enhancement An improvement of existing functionality label Apr 1, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 1, 2021
@lafriks
Copy link
Member

lafriks commented Apr 1, 2021

Can't we just check strings.Contains for text/html?

@techknowlogick techknowlogick added this to the 1.15.0 milestone Apr 1, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 1, 2021
@6543
Copy link
Member

6543 commented Apr 1, 2021

.

@6543 6543 merged commit 43fb492 into go-gitea:master Apr 1, 2021
@a1012112796 a1012112796 deleted the simple-404 branch April 1, 2021 15:14
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
6 participants
@a1012112796 @lafriks @6543 @lunny @techknowlogick @GiteaBot