Skip to content

Check if label template exist first (#14384) #14389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 18, 2021
Merged

Check if label template exist first (#14384) #14389

merged 2 commits into from
Jan 18, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 18, 2021 •
edited
Loading

Partial Backport of #14384

fix #14327

@6543 6543 added the type/bug label Jan 18, 2021
@6543 6543 added this to the 1.13.2 milestone Jan 18, 2021
@6543
Check if label template exist first (go-gitea#14384)
85b9414 
* add check

* refactor

* rollback repo on error after session closed
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 18, 2021
@6543 6543 force-pushed the backport_partialy_14384_Check-if-label-template-exist-first branch from ae93966 to 85b9414 Compare January 18, 2021 20:02
@lafriks
Copy link
Member

lafriks commented Jan 18, 2021

🚀

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 18, 2021
@lafriks lafriks merged commit cf20ebc into go-gitea:release/v1.13 Jan 18, 2021
@lafriks lafriks deleted the backport_partialy_14384_Check-if-label-template-exist-first branch January 18, 2021 22:27
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.13.2
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @lafriks @zeripath @GiteaBot