Skip to content

Add edit, delete and reaction support to code review comments on issue page #14339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 17, 2021
Merged

Add edit, delete and reaction support to code review comments on issue page #14339

merged 4 commits into from
Jan 17, 2021

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Jan 14, 2021 •
edited
Loading

Screenshot:
image

@lafriks lafriks added the type/enhancement An improvement of existing functionality label Jan 14, 2021
@lafriks lafriks added this to the 1.14.0 milestone Jan 14, 2021
@lafriks lafriks force-pushed the feat/review_comments branch from 0780e49 to 7419cd3 Compare January 14, 2021 21:23
@codecov-io
Copy link

codecov-io commented Jan 14, 2021 •
edited
Loading

Codecov Report

Merging #14339 (ec82ba3) into master (acb1ceb) will increase coverage by 0.00%.
The diff coverage is 53.84%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14339   +/-   ##
=======================================
  Coverage   41.84%   41.84%           
=======================================
  Files         744      744           
  Lines       79714    79727   +13     
=======================================
+ Hits        33355    33362    +7     
- Misses      40852    40856    +4     
- Partials     5507     5509    +2
Impacted Files Coverage Δ
routers/repo/issue.go 38.36% <53.84%> (+0.12%) ⬆️
modules/log/event.go 58.96% <0.00%> (-0.95%) ⬇️
models/repo_list.go 78.76% <0.00%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acb1ceb...ec82ba3. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 14, 2021
@lafriks lafriks force-pushed the feat/review_comments branch from 9f416bf to ef98881 Compare January 14, 2021 22:26
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 17, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 17, 2021
@lafriks
Copy link
Member Author

lafriks commented Jan 17, 2021

🚀

@lafriks lafriks merged commit ca63a9d into go-gitea:master Jan 17, 2021
@lafriks lafriks deleted the feat/review_comments branch January 17, 2021 17:29
@KN4CK3R KN4CK3R mentioned this pull request Jan 17, 2021
Merged
KN4CK3R added a commit to KN4CK3R/gitea that referenced this pull request Jan 17, 2021
@KN4CK3R
Reverted changes because of go-gitea#14339.
41e8279
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 19, 2021
@a1012112796
Merge branch 'master' into imap
560f48a 
* master: (27 commits)
  Use path not filepath in routers/editor (go-gitea#14390)
  Display error if twofaSecret cannot be retrieved (go-gitea#14372)
  Check if label template exist first (go-gitea#14384)
  Allow passcode invalid error to appear (go-gitea#14371)
  exclude authored PRs from Review Requested filter (go-gitea#14368)
  Upgrade blevesearch dependency to v2.0.1 (go-gitea#14346)
  Implement ghost comment mitigation (go-gitea#14349)
  Add edit, delete and reaction support to code review comments on issue page (go-gitea#14339)
  Add review requested filter on pull request overview (go-gitea#13701)
  escape branch names in compare url (go-gitea#14364)
  label and milestone webhooks on issue/pull creation (go-gitea#14363)
  Fix middlewares sequences (go-gitea#14354)
  Sort issue search results by revelance (go-gitea#14353)
  KanBan: be able to set default board (go-gitea#14147)
  ...
@lafriks lafriks mentioned this pull request Jan 23, 2021
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lafriks @codecov-io @lunny @6543 @GiteaBot