Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 8, 2021

The bug prevents user login when use with file sessions.

fix #14271

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 8, 2021
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix it

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 8, 2021
@6543 6543 mentioned this pull request Jan 8, 2021
6 tasks
@codecov-io
Copy link

Codecov Report

Merging #14287 (04c8a10) into master (c1e30c9) will decrease coverage by 0.02%.
The diff coverage is 36.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14287      +/-   ##
==========================================
- Coverage   41.83%   41.80%   -0.03%     
==========================================
  Files         743      743              
  Lines       79395    79401       +6     
==========================================
- Hits        33212    33197      -15     
- Misses      40718    40740      +22     
+ Partials     5465     5464       -1     
Impacted Files Coverage Δ
routers/routes/recovery.go 28.30% <0.00%> (-1.11%) ⬇️
routers/routes/chi.go 38.09% <66.66%> (+0.29%) ⬆️
modules/middlewares/virtual.go 8.33% <0.00%> (-23.96%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
models/gpg_key.go 53.33% <0.00%> (-0.58%) ⬇️
services/pull/pull.go 43.06% <0.00%> (+0.49%) ⬆️
modules/queue/workerpool.go 60.00% <0.00%> (+1.22%) ⬆️
modules/queue/unique_queue_disk_channel.go 55.38% <0.00%> (+1.53%) ⬆️
modules/git/repo_commit_nogogit.go 65.00% <0.00%> (+1.66%) ⬆️
modules/indexer/stats/db.go 60.00% <0.00%> (+12.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4614060...04c8a10. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 8, 2021
@lafriks lafriks added this to the 1.14.0 milestone Jan 8, 2021
@lafriks lafriks merged commit ce43d38 into go-gitea:master Jan 8, 2021
@lunny lunny deleted the lunny/fix_chi_session branch January 8, 2021 12:22
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 14, 2021
* master: (252 commits)
  Issues overview should not show issues from archived repos (go-gitea#13220)
  Display SVG files as images instead of text (go-gitea#14101)
  [skip ci] Updated translations via Crowdin
  Update docs to clarify issues raised in go-gitea#14272 (go-gitea#14318)
  [skip ci] Updated translations via Crowdin
  [Refactor] Passwort Hash/Set (go-gitea#14282)
  Add option to change username to the admin panel (go-gitea#14229)
  fix mailIssueCommentBatch for pull request (go-gitea#14252)
  Remove self from MAINTAINERS (go-gitea#14286)
  Do not reload page after adding comments in Pull Request reviews (go-gitea#13877)
  Fix session bug when introduce chi (go-gitea#14287)
  [skip ci] Updated translations via Crowdin
  Add secure/httpOnly attributes to the lang cookie (go-gitea#9690) (go-gitea#14279)
  Some code improvements (go-gitea#14266)
  [skip ci] Updated translations via Crowdin
  Fix wrong type on hooktask to convert typ from char(16) to varchar(16) (go-gitea#14148)
  Upgrade XORM links in documentation. (go-gitea#14265)
  Check permission for the appropriate unit type (go-gitea#14261)
  Add compliance check for windows to ensure cross platform build (go-gitea#14260)
  [skip ci] Updated translations via Crowdin
  ...
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2FA issues in dev version
5 participants