Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 6, 2021

Fix some wrong codes.

@lunny lunny added the type/bug label Jan 6, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 6, 2021
@techknowlogick techknowlogick added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 6, 2021
@techknowlogick techknowlogick added this to the 1.14.0 milestone Jan 6, 2021
@techknowlogick techknowlogick added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 6, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 6, 2021
@codecov-io
Copy link

Codecov Report

Merging #14266 (0aa8cde) into master (d2ee122) will decrease coverage by 0.03%.
The diff coverage is 5.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14266      +/-   ##
==========================================
- Coverage   41.86%   41.83%   -0.04%     
==========================================
  Files         742      743       +1     
  Lines       79324    79393      +69     
==========================================
+ Hits        33209    33211       +2     
- Misses      40650    40718      +68     
+ Partials     5465     5464       -1     
Impacted Files Coverage Δ
models/migrations/migrations.go 2.28% <0.00%> (-0.16%) ⬇️
models/migrations/v156.go 0.00% <0.00%> (ø)
models/migrations/v161.go 0.00% <0.00%> (ø)
models/migrations/v165.go 0.00% <0.00%> (ø)
models/webhook.go 69.06% <ø> (ø)
routers/repo/lfs.go 0.00% <0.00%> (ø)
services/webhook/webhook.go 52.42% <33.33%> (ø)
modules/lfs/server.go 44.41% <50.00%> (-0.15%) ⬇️
services/pull/pull.go 43.06% <100.00%> (+0.28%) ⬆️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8688c2b...0aa8cde. Read the comment docs.

@zeripath zeripath merged commit 3c96a37 into go-gitea:master Jan 6, 2021
@lunny lunny deleted the lunny/add_close_back branch January 7, 2021 01:32
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 14, 2021
* master: (252 commits)
  Issues overview should not show issues from archived repos (go-gitea#13220)
  Display SVG files as images instead of text (go-gitea#14101)
  [skip ci] Updated translations via Crowdin
  Update docs to clarify issues raised in go-gitea#14272 (go-gitea#14318)
  [skip ci] Updated translations via Crowdin
  [Refactor] Passwort Hash/Set (go-gitea#14282)
  Add option to change username to the admin panel (go-gitea#14229)
  fix mailIssueCommentBatch for pull request (go-gitea#14252)
  Remove self from MAINTAINERS (go-gitea#14286)
  Do not reload page after adding comments in Pull Request reviews (go-gitea#13877)
  Fix session bug when introduce chi (go-gitea#14287)
  [skip ci] Updated translations via Crowdin
  Add secure/httpOnly attributes to the lang cookie (go-gitea#9690) (go-gitea#14279)
  Some code improvements (go-gitea#14266)
  [skip ci] Updated translations via Crowdin
  Fix wrong type on hooktask to convert typ from char(16) to varchar(16) (go-gitea#14148)
  Upgrade XORM links in documentation. (go-gitea#14265)
  Check permission for the appropriate unit type (go-gitea#14261)
  Add compliance check for windows to ensure cross platform build (go-gitea#14260)
  [skip ci] Updated translations via Crowdin
  ...
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants