Skip to content

Conversation

a1012112796
Copy link
Member

fix #14250

fix go-gitea#14250

Signed-off-by: a1012112796 <1012112796@qq.com>
@lunny lunny added the type/bug label Jan 5, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 5, 2021
@codecov-io
Copy link

codecov-io commented Jan 5, 2021

Codecov Report

Merging #14252 (4f36153) into master (7369282) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14252      +/-   ##
==========================================
+ Coverage   41.77%   41.78%   +0.01%     
==========================================
  Files         743      743              
  Lines       79461    79464       +3     
==========================================
+ Hits        33196    33207      +11     
+ Misses      40800    40792       -8     
  Partials     5465     5465              
Impacted Files Coverage Δ
services/mailer/mail_issue.go 63.95% <100.00%> (+1.30%) ⬆️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
models/gpg_key.go 53.90% <0.00%> (+0.57%) ⬆️
modules/log/event.go 59.90% <0.00%> (+0.94%) ⬆️
modules/git/repo_commit_nogogit.go 65.00% <0.00%> (+1.66%) ⬆️
models/unit.go 49.31% <0.00%> (+2.73%) ⬆️
modules/indexer/stats/db.go 60.00% <0.00%> (+12.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7369282...4f36153. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 9, 2021
@zeripath zeripath merged commit d989247 into go-gitea:master Jan 9, 2021
@techknowlogick techknowlogick added this to the 1.14.0 milestone Jan 9, 2021
@a1012112796 a1012112796 deleted the fix_14250 branch January 10, 2021 16:01
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 10, 2021
fix go-gitea#14250

Signed-off-by: a1012112796 <1012112796@qq.com>
@a1012112796 a1012112796 added the backport/done All backports for this PR have been created label Jan 10, 2021
lunny pushed a commit that referenced this pull request Jan 11, 2021
fix #14250

Signed-off-by: a1012112796 <1012112796@qq.com>
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 14, 2021
* master: (252 commits)
  Issues overview should not show issues from archived repos (go-gitea#13220)
  Display SVG files as images instead of text (go-gitea#14101)
  [skip ci] Updated translations via Crowdin
  Update docs to clarify issues raised in go-gitea#14272 (go-gitea#14318)
  [skip ci] Updated translations via Crowdin
  [Refactor] Passwort Hash/Set (go-gitea#14282)
  Add option to change username to the admin panel (go-gitea#14229)
  fix mailIssueCommentBatch for pull request (go-gitea#14252)
  Remove self from MAINTAINERS (go-gitea#14286)
  Do not reload page after adding comments in Pull Request reviews (go-gitea#13877)
  Fix session bug when introduce chi (go-gitea#14287)
  [skip ci] Updated translations via Crowdin
  Add secure/httpOnly attributes to the lang cookie (go-gitea#9690) (go-gitea#14279)
  Some code improvements (go-gitea#14266)
  [skip ci] Updated translations via Crowdin
  Fix wrong type on hooktask to convert typ from char(16) to varchar(16) (go-gitea#14148)
  Upgrade XORM links in documentation. (go-gitea#14265)
  Check permission for the appropriate unit type (go-gitea#14261)
  Add compliance check for windows to ensure cross platform build (go-gitea#14260)
  [skip ci] Updated translations via Crowdin
  ...
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No email notifications are sent for PR's if issues repo unit is disabled
6 participants