Skip to content

Add option to change username to the admin panel #14229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Jan 10, 2021
Merged

Add option to change username to the admin panel #14229

merged 30 commits into from
Jan 10, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 3, 2021

follow up of #2129

close #1818

@6543 6543 added the type/enhancement An improvement of existing functionality label Jan 3, 2021
@6543 6543 added this to the 1.14.0 milestone Jan 3, 2021
@6543 6543 mentioned this pull request Jan 3, 2021
Closed
6543
6543 commented Jan 3, 2021
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 3, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 3, 2021
@lafriks
Copy link
Member

lafriks commented Jan 3, 2021

Lint fails

6543
6543 commented Jan 3, 2021
View reviewed changes
Copy link
Member Author

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I'm fine with it now :)

@lafriks lint fixed

@codecov-io
Copy link

codecov-io commented Jan 3, 2021 •
edited
Loading

Codecov Report

Merging #14229 (cd2f5aa) into master (7369282) will increase coverage by 0.06%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14229      +/-   ##
==========================================
+ Coverage   41.77%   41.84%   +0.06%     
==========================================
  Files         743      743              
  Lines       79461    79465       +4     
==========================================
+ Hits        33196    33250      +54     
+ Misses      40800    40743      -57     
- Partials     5465     5472       +7
Impacted Files Coverage Δ
modules/auth/admin.go 33.33% <ø> (+33.33%) ⬆️
models/user.go 54.40% <20.00%> (ø)
routers/admin/users.go 39.16% <50.00%> (+11.38%) ⬆️
routers/user/setting/profile.go 39.88% <80.00%> (+0.99%) ⬆️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
modules/log/event.go 59.90% <0.00%> (+0.94%) ⬆️
modules/queue/unique_queue_disk_channel.go 55.38% <0.00%> (+1.53%) ⬆️
modules/log/file.go 75.20% <0.00%> (+1.60%) ⬆️
modules/git/repo_commit_nogogit.go 65.00% <0.00%> (+1.66%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7369282...cd2f5aa. Read the comment docs.

6543
6543 commented Jan 3, 2021
View reviewed changes
Copy link
Member Author

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

6543
6543 commented Jan 4, 2021
View reviewed changes
@6543 6543 force-pushed the Bwko/change_username branch from c8dcb62 to ed4573b Compare January 4, 2021 00:26
@6543
Copy link
Member Author

6543 commented Jan 5, 2021

@lafriks time to review again?

techknowlogick
techknowlogick reviewed Jan 9, 2021
View reviewed changes
6543
6543 commented Jan 9, 2021
View reviewed changes
@6543
Copy link
Member Author

6543 commented Jan 9, 2021

@techknowlogick done

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 10, 2021
@lafriks lafriks merged commit 6b3b6f1 into go-gitea:master Jan 10, 2021
@lafriks lafriks deleted the Bwko/change_username branch January 10, 2021 12:14
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 14, 2021
@a1012112796
Merge branch 'master' into imap
77cedeb 
* master: (252 commits)
  Issues overview should not show issues from archived repos (go-gitea#13220)
  Display SVG files as images instead of text (go-gitea#14101)
  [skip ci] Updated translations via Crowdin
  Update docs to clarify issues raised in go-gitea#14272 (go-gitea#14318)
  [skip ci] Updated translations via Crowdin
  [Refactor] Passwort Hash/Set (go-gitea#14282)
  Add option to change username to the admin panel (go-gitea#14229)
  fix mailIssueCommentBatch for pull request (go-gitea#14252)
  Remove self from MAINTAINERS (go-gitea#14286)
  Do not reload page after adding comments in Pull Request reviews (go-gitea#13877)
  Fix session bug when introduce chi (go-gitea#14287)
  [skip ci] Updated translations via Crowdin
  Add secure/httpOnly attributes to the lang cookie (go-gitea#9690) (go-gitea#14279)
  Some code improvements (go-gitea#14266)
  [skip ci] Updated translations via Crowdin
  Fix wrong type on hooktask to convert typ from char(16) to varchar(16) (go-gitea#14148)
  Upgrade XORM links in documentation. (go-gitea#14265)
  Check permission for the appropriate unit type (go-gitea#14261)
  Add compliance check for windows to ensure cross platform build (go-gitea#14260)
  [skip ci] Updated translations via Crowdin
  ...
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick left review comments

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

Allow update any login name from admin account
7 participants
@6543 @lafriks @codecov-io @techknowlogick @zeripath @GiteaBot @Bwko