Skip to content

Fix 500 on pull view page if user is not loged in #14885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2021
Merged

Fix 500 on pull view page if user is not loged in #14885

merged 1 commit into from
Mar 4, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Mar 4, 2021 •
edited
Loading

@6543 6543 added the type/bug label Mar 4, 2021
@6543 6543 added this to the 1.14.0 milestone Mar 4, 2021
@6543 6543 force-pushed the fix_nil-exeption-in-pull-view branch from 1e8f8d9 to 8918c0f Compare March 4, 2021 17:55
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 4, 2021
@6543 6543 mentioned this pull request Mar 4, 2021
Merged
@6543 6543 added the backport/done All backports for this PR have been created label Mar 4, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 4, 2021
@6543 6543 merged commit 11229ca into go-gitea:master Mar 4, 2021
@6543 6543 deleted the fix_nil-exeption-in-pull-view branch March 4, 2021 18:28
@lunny
Copy link
Member

lunny commented Mar 5, 2021 •
edited
Loading

Please send back port

@6543
Copy link
Member Author

6543 commented Mar 5, 2021

@lunny #14886

@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @lunny @zeripath @jolheiser @GiteaBot