for build/generate-emoji.go it's fine - but for the gitea binary can we init jsoniter.ConfigCompatibleWithStandardLibrary once?

that's not initing - it's just a reference

This also needs chi to migrate to jsoniter too.

https://gitea.com/go-chi/binding/pulls/1

@zeripath I think you can update our binding middleware here ...

... done

json-iterator/go is not always compatible with encoding/json, see their issue tracker for examples. I personally have given up on it already.

goccy/go-json may be a better alternative, it claims to be faster than json-iterator/go, but it's probably not as well tested as encoding/json.

we need benchmarks for gitea!!!

@silverwind we only need to care about the incompatibilities that actually matter - if we're not hitting anything right now it's easy enough to handle in the future.

Not wedded to json-iterator though - looking at the code it certainly could be a lot faster.

My main reason was that it had a streaming interface but its API is not great.

Happy to try go-json if you think that's better.

iterator is is opensource why not improve it upstream ... & this are now topics witch we should talk about in discord ... locking this issue now :D

we need benchmarks for gitea!!!

So in regards to JSON libraries our testsuite as a whole is actually a rather good benchmark.

It would be useful though to have a benchmark that just pushes files to a repo over the API as I know that that is something we're surprisingly slow at.