Skip to content

use gomod support w/ xgo #14836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2021
Merged

use gomod support w/ xgo #14836

merged 1 commit into from
Mar 1, 2021

Conversation

techknowlogick
Copy link
Member

as title

@techknowlogick techknowlogick added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 1, 2021
@techknowlogick techknowlogick added this to the 1.14.0 milestone Mar 1, 2021
@codecov-io
Copy link

Codecov Report

Merging #14836 (b612ace) into master (a4148c0) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14836      +/-   ##
==========================================
- Coverage   42.15%   42.07%   -0.08%     
==========================================
  Files         774      774              
  Lines       82539    82539              
==========================================
- Hits        34794    34729      -65     
- Misses      42081    42149      +68     
+ Partials     5664     5661       -3
Impacted Files Coverage Δ
modules/forms/repo_form.go 25.16% <0.00%> (-12.59%) ⬇️
modules/forms/user_form.go 29.26% <0.00%> (-10.98%) ⬇️
modules/indexer/issues/indexer.go 51.79% <0.00%> (-8.21%) ⬇️
modules/avatar/avatar.go 50.00% <0.00%> (-4.77%) ⬇️
modules/indexer/code/bleve.go 65.04% <0.00%> (-4.43%) ⬇️
modules/charset/charset.go 68.53% <0.00%> (-2.25%) ⬇️
modules/indexer/code/elastic_search.go 0.00% <0.00%> (-1.73%) ⬇️
services/gitdiff/gitdiff.go 73.69% <0.00%> (-1.45%) ⬇️
services/pull/pull.go 41.66% <0.00%> (-0.50%) ⬇️
models/gpg_key.go 54.07% <0.00%> (+0.56%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4148c0...b612ace. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 1, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 1, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 1, 2021
@lunny lunny merged commit d801a15 into go-gitea:master Mar 1, 2021
@techknowlogick techknowlogick deleted the xgo-fixes branch March 1, 2021 03:55
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@techknowlogick @codecov-io @lunny @6543 @GiteaBot