Skip to content

Fix misleading sentence #14829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2021
Merged

Fix misleading sentence #14829

merged 1 commit into from
Feb 28, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Feb 28, 2021 •
edited
Loading

The counter show's how many unique users who have created issues are now closed.
But you get a other meaning (see screenshot)

Bildschirmfoto zu 2021-02-28 03-35-42

ref for .Activity.ClosedIssueAuthorCount:

gitea/models/repo_activity.go

Lines 275 to 280 in 4e7e3bd

// Closed issue authors
sess = issuesForActivityStatement(repoID, fromTime, true, false)
if _, err = sess.Select("count(distinct issue.poster_id) as `count`").Table("issue").Get(&count); err != nil {
return err
}
stats.ClosedIssueAuthorCount = count

@6543 6543 added type/bug topic/ui Change the appearance of the Gitea UI labels Feb 28, 2021
@6543 6543 added this to the 1.14.0 milestone Feb 28, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 28, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 28, 2021
@zeripath zeripath merged commit b4b4d76 into go-gitea:master Feb 28, 2021
@zeripath zeripath deleted the fix-wording-issue branch February 28, 2021 07:54
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@zeripath zeripath zeripath approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @zeripath @a1012112796 @GiteaBot