Skip to content

Conversation

zeripath
Copy link
Contributor

Instead of causing a log.Fatal, we should handle broken OAuth2
providers by disabling them.

Fix #8930

Signed-off-by: Andrew Thornton art27@cantab.net

Instead of causing a log.Fatal, we should handle broken OAuth2
providers by disabling them.

Fix go-gitea#8930

Signed-off-by: Andrew Thornton <art27@cantab.net>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 25, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 26, 2021
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 50208e9 into go-gitea:master Feb 26, 2021
@zeripath zeripath deleted the fix-8930-Disable-broken-oauth-providers-at-startup-instead-of-fatalling branch February 26, 2021 10:10
zeripath added a commit to zeripath/gitea that referenced this pull request Feb 26, 2021
Backport go-gitea#14802

Instead of causing a log.Fatal, we should handle broken OAuth2
providers by disabling them.

Fix go-gitea#8930

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
6543 pushed a commit that referenced this pull request Feb 26, 2021
Backport #14802

Instead of causing a log.Fatal, we should handle broken OAuth2
providers by disabling them.

Fix #8930

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@zeripath zeripath added the backport/done All backports for this PR have been created label Mar 1, 2021
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gitea should fail gracefully when OIDC IDP has problems
4 participants