Skip to content

Conversation

parnic
Copy link
Contributor

@parnic parnic commented Feb 24, 2021

This pull request adds support for configuring the default merge style for pull requests in a repository.

Fixes #12293

Note: I haven't added tests or anything yet, mostly because I wanted to make sure this was

  1. Something you all are willing to merge at all
  2. Meets contribution guidelines/requirements.

@6543 6543 added the type/enhancement An improvement of existing functionality label Feb 24, 2021
@6543 6543 added this to the 1.15.0 milestone Feb 24, 2021
This was originally based on the 1.13.2 branch, but it seems this has changed in master
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 24, 2021
There's no real need for this as the default handles a missing setting.
@lunny
Copy link
Member

lunny commented Feb 25, 2021

DefaultMergeStyle should be selected on pull request view merge dropdown button.

@parnic
Copy link
Contributor Author

parnic commented Feb 25, 2021

DefaultMergeStyle should be selected on pull request view merge dropdown button.

@lunny do you mean templates/repo/issue/view_content/pull.tmpl? If so, that's what the routers/repo/issue.go change is accomplishing. If not, where do you mean?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 4, 2021
@pat-s
Copy link
Member

pat-s commented Mar 17, 2021

@parnic Could you resolve the merge conflicts? :) there are already two approvals.

@6543
Copy link
Member

6543 commented Mar 27, 2021

🚀

@6543 6543 merged commit f4d2749 into go-gitea:master Mar 27, 2021
@parnic parnic deleted the add-default-merge-style branch March 27, 2021 15:19
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to specify default PR merge option
8 participants