Skip to content

Conversation

6543
Copy link
Member

@6543 6543 commented Feb 22, 2021

as title

@6543 6543 added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Feb 22, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 22, 2021
@delvh
Copy link
Member

delvh commented Feb 22, 2021

What exactly is the benefit of updating the translations not on a push, but (what even is the interval? It's never specified anywhere) hourly?
Normally I'd say that updating on a push should be enough as no other changes can be performed.
Or is the mechanism notifying of a push buggy?

@techknowlogick
Copy link
Member

techknowlogick commented Feb 22, 2021

@delvh sometimes we get many translation commits even in a day, and they also occasionally slow down merges as PRs need to be tested against the latest commits in master before merging and translation commits sometimes sneak in.

ETA: We would configure the frequency in Drone, and the consensus is to set it as daily.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 22, 2021
@lunny lunny merged commit 1d63e17 into go-gitea:master Feb 22, 2021
@6543 6543 deleted the ci_translate-as-cron branch February 22, 2021 23:20
@6543
Copy link
Member Author

6543 commented Feb 22, 2021

@daily cronjob created

@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants