Skip to content

Fix repo-restore bug with poster not replaced #14759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 22, 2021
Merged

Fix repo-restore bug with poster not replaced #14759

merged 6 commits into from
Feb 22, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 20, 2021 •
edited
Loading

Currently, when execute restore-repo command, the user will not be replaced by link account because the service type hasn't been stored on the database correctly.

@lunny lunny added type/bug pr/wip This PR is not ready for review backport/v1.13 labels Feb 20, 2021
@codecov-io
Copy link

codecov-io commented Feb 20, 2021 •
edited
Loading

Codecov Report

Merging #14759 (b08de5e) into master (487f2ee) will decrease coverage by 0.01%.
The diff coverage is 40.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14759      +/-   ##
==========================================
- Coverage   42.21%   42.19%   -0.02%     
==========================================
  Files         767      771       +4     
  Lines       81624    82088     +464     
==========================================
+ Hits        34458    34639     +181     
- Misses      41531    41799     +268     
- Partials     5635     5650      +15
Impacted Files Coverage Δ
models/action.go 48.52% <0.00%> (-2.42%) ⬇️
models/migrations/migrations.go 2.59% <ø> (ø)
models/migrations/v166.go 0.00% <0.00%> (ø)
models/migrations/v172.go 0.00% <0.00%> (ø)
models/migrations/v173.go 0.00% <0.00%> (ø)
models/session.go 0.00% <0.00%> (ø)
models/user.go 53.05% <ø> (+0.38%) ⬆️
modules/context/context.go 58.05% <0.00%> (-0.45%) ⬇️
modules/indexer/code/elastic_search.go 1.72% <0.00%> (-0.02%) ⬇️
modules/migrations/dump.go 0.00% <0.00%> (ø)
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b56c19d...b08de5e. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 20, 2021
@lunny lunny force-pushed the lunny/fix_repo_restore branch from fb242fb to 935b947 Compare February 21, 2021 10:50
@lunny lunny removed the pr/wip This PR is not ready for review label Feb 21, 2021
@lunny lunny changed the title WIP: Fix restore bug Fix restore bug Feb 21, 2021
@lunny lunny force-pushed the lunny/fix_repo_restore branch from 935b947 to b08de5e Compare February 21, 2021 10:52
@lunny lunny added this to the 1.14.0 milestone Feb 21, 2021
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 21, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 21, 2021
@lunny lunny changed the title Fix restore bug Fix repo-restore bug with poster not replaced Feb 21, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 21, 2021
@lunny
Copy link
Member Author

lunny commented Feb 22, 2021

make L-G-T-M work

@lunny lunny merged commit e79dae2 into go-gitea:master Feb 22, 2021
@lunny lunny deleted the lunny/fix_repo_restore branch February 22, 2021 03:57
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

+2 more reviewers

@khmarbaise khmarbaise khmarbaise approved these changes

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
8 participants
@lunny @codecov-io @khmarbaise @lafriks @zeripath @GiteaBot @jolheiser @6543