Skip to content

Add Image Diff options in Diff view #14450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Feb 27, 2021
Merged

Add Image Diff options in Diff view #14450

merged 18 commits into from
Feb 27, 2021

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Jan 24, 2021 •
edited by 6543
Loading

Implemented GitHub style image diff.

@6543 6543 added type/feature Completely new functionality. Can only be merged if feature freeze is not active. topic/ui Change the appearance of the Gitea UI labels Jan 24, 2021
@codecov-io
Copy link

codecov-io commented Jan 24, 2021 •
edited
Loading

Codecov Report

Merging #14450 (6572f6f) into master (487f2ee) will increase coverage by 0.00%.
The diff coverage is 42.15%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #14450    +/-   ##
========================================
  Coverage   42.21%   42.22%            
========================================
  Files         767      771     +4     
  Lines       81624    82078   +454     
========================================
+ Hits        34458    34657   +199     
- Misses      41531    41777   +246     
- Partials     5635     5644     +9
Impacted Files Coverage Δ
models/action.go 48.52% <0.00%> (-2.42%) ⬇️
models/migrations/migrations.go 2.59% <ø> (ø)
models/migrations/v166.go 0.00% <0.00%> (ø)
models/migrations/v172.go 0.00% <0.00%> (ø)
models/migrations/v173.go 0.00% <0.00%> (ø)
models/session.go 0.00% <0.00%> (ø)
models/user.go 53.05% <ø> (+0.38%) ⬆️
modules/context/context.go 58.05% <0.00%> (-0.45%) ⬇️
modules/indexer/code/elastic_search.go 1.72% <0.00%> (-0.02%) ⬇️
modules/migrations/github.go 77.77% <0.00%> (-1.99%) ⬇️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b56c19d...6572f6f. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 24, 2021
a1012112796
a1012112796 reviewed Jan 25, 2021
View reviewed changes
6543
6543 reviewed Jan 26, 2021
View reviewed changes
@6543 6543 added this to the 1.15.0 milestone Jan 26, 2021
@6543 6543 added type/enhancement An improvement of existing functionality and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Jan 27, 2021
@6543 6543 modified the milestones: 1.15.0, 1.14.0 Jan 27, 2021
@silverwind
Copy link
Member

Can you move it to separate files? web_src/{js,less}/features/imagediff.{js,less}?

@6543
Copy link
Member

6543 commented Jan 28, 2021

The default "Side by Side"-view is only loaded after klicking on it

@KN4CK3R
Copy link
Member Author

KN4CK3R commented Jan 29, 2021

How do you get this error? I tested two browser and both "auto activate" the Side by Side view.

@6543
Copy link
Member

6543 commented Jan 29, 2021

SeideBySide is selected by default but pictures are not loaded ...

Browser: 84.0.2 (64-bit) Firefox OS: linux 5.10.8 artix

@6543 6543 mentioned this pull request Feb 11, 2021
Closed
@6543
Copy link
Member

6543 commented Feb 25, 2021 •
edited
Loading

@KN4CK3R -> Video of bug: https://cloud.obermui.de/s/6SDDPGACA4Hjasz

(No error message in web console :/ )

@KN4CK3R
Copy link
Member Author

KN4CK3R commented Feb 25, 2021

I was able to reproduce the error on the PR site. Don't know why but the active class doesn't get added by Semantic there.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 25, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 27, 2021
@lafriks lafriks changed the title Feature Image Diff Add Image Diff options in Pull Request Diff view Feb 27, 2021
@6543
Copy link
Member

6543 commented Feb 27, 2021

🚀

@6543 6543 merged commit 904a26c into go-gitea:master Feb 27, 2021
@delvh delvh mentioned this pull request Mar 3, 2021
Open
@KN4CK3R KN4CK3R mentioned this pull request Mar 3, 2021
Merged
@KN4CK3R KN4CK3R changed the title Add Image Diff options in Pull Request Diff view Add Image Diff options in Diff view Mar 6, 2021
@KN4CK3R KN4CK3R deleted the feature-image-diff branch April 6, 2021 20:39
@camlafit camlafit mentioned this pull request Apr 16, 2021
Closed
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@6543 6543 6543 approved these changes

+1 more reviewer

@a1012112796 a1012112796 a1012112796 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
8 participants
@KN4CK3R @codecov-io @silverwind @6543 @lafriks @a1012112796 @GiteaBot @zeripath