Skip to content

Fix bug isEnd detection on getIssues/getPullRequests #13299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2020
Merged

Fix bug isEnd detection on getIssues/getPullRequests #13299

merged 1 commit into from
Oct 25, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 25, 2020

As title.

@lunny lunny added this to the 1.14.0 milestone Oct 25, 2020
@codecov-io
Copy link

Codecov Report

Merging #13299 into master will decrease coverage by 0.00%.
The diff coverage is 45.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13299      +/-   ##
==========================================
- Coverage   42.10%   42.10%   -0.01%     
==========================================
  Files         689      689              
  Lines       75711    75721      +10     
==========================================
+ Hits        31878    31882       +4     
- Misses      38606    38611       +5     
- Partials     5227     5228       +1
Impacted Files Coverage Δ
modules/migrations/gitlab.go 1.03% <0.00%> (-0.02%) ⬇️
modules/migrations/github.go 80.19% <80.00%> (-0.61%) ⬇️
modules/indexer/stats/db.go 52.17% <0.00%> (-8.70%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
modules/git/repo.go 46.19% <0.00%> (-0.51%) ⬇️
modules/queue/unique_queue_disk_channel.go 55.38% <0.00%> (+1.53%) ⬆️
modules/charset/charset.go 73.03% <0.00%> (+4.49%) ⬆️
modules/avatar/avatar.go 54.76% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eab5837...1328484. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 25, 2020
zeripath
zeripath approved these changes Oct 25, 2020
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this fixes anything but it looks fine

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 25, 2020
@lunny
Copy link
Member Author

lunny commented Oct 25, 2020

I don't understand why this fixes anything but it looks fine

Sorry I haven't explain this bug.

When the parameter getIssues(page, perPage int) perPage > maxPerPage, it will return isEnd as true always on first page. So that you can always only get only 1 page. that means 100 issues.

If a repository has over 100 issues, only 100 issues will be migrated.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 25, 2020
@techknowlogick techknowlogick merged commit d130cd1 into go-gitea:master Oct 25, 2020
@techknowlogick
Copy link
Member

please backport :)

lunny added a commit to lunny/gitea that referenced this pull request Oct 25, 2020
@lunny
Fix bug isEnd detection on getIssues/getPullRequests (go-gitea#13299)
daeeea8
@lunny lunny mentioned this pull request Oct 25, 2020
Merged
@lunny lunny deleted the lunny/fix_migration_is_end branch October 25, 2020 06:13
lafriks pushed a commit that referenced this pull request Oct 25, 2020
@lunny
Fix bug isEnd detection on getIssues/getPullRequests (#13299) (#13301)
151daf7
@zeripath zeripath added the backport/done All backports for this PR have been created label Oct 25, 2020
@6543
Copy link
Member

6543 commented Oct 25, 2020

@lunny sorry I did missed that somehow :/

ivanvc added a commit to ivanvc/gitea that referenced this pull request Oct 27, 2020
@ivanvc
Merge remote-tracking branch 'origin/master' into ensure-user-email-i…
e259244 
…s-stored-in-email-address-table

* origin/master:
  [UI] Hide consecutive additions and removals of the same label (go-gitea#13315)
  [skip ci] Updated translations via Crowdin
  Fix send mail (go-gitea#13312)
  [skip ci] Updated translations via Crowdin
  Deny wrong pull (go-gitea#13308)
  Group Label Changed Comments in timeline (go-gitea#13304)
  [skip ci] Updated translations via Crowdin
  Attempt to handle unready PR in tests (go-gitea#13305)
  go-gitea#12897 - add mastodon provider (go-gitea#13293)
  [skip ci] Updated translations via Crowdin
  Fix Storage mapping (go-gitea#13297)
  Update Mirror IsEmpty status on synchronize (go-gitea#13185)
  Fix bug isEnd detection on getIssues/getPullRequests (go-gitea#13299)
  systemd service: Add commented PATH environment option for Git prefix (go-gitea#13170)
  Sendmail command (go-gitea#13079)
  Various UI and arc-green fixes (go-gitea#13291)
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @codecov-io @techknowlogick @6543 @zeripath @GiteaBot