Skip to content

Various UI and arc-green fixes #13291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 24, 2020
Merged

Various UI and arc-green fixes #13291

merged 4 commits into from
Oct 24, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Oct 24, 2020 •
edited
Loading

  • introduce variable for border-radius value
  • fix some white borders in arc-green
  • add text selection and placeholder in arc-green
  • tweak branch item list footer
  • fix border radii in dropdowns
  • more things I forgot

Screen Shot 2020-10-24 at 13 18 32

Screen Shot 2020-10-24 at 13 39 23

image

image

@silverwind
Various UI and arc-green fixes
1d9f82d 
- introduce variable for border-radius value
- fix some white borders in arc-green
- add text selection and placeholder in arc-green
- tweak branch list footer
- more things I forgot
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 24, 2020
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Oct 24, 2020
@lafriks lafriks added this to the 1.14.0 milestone Oct 24, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 24, 2020
@techknowlogick techknowlogick added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Oct 24, 2020
@codecov-io
Copy link

codecov-io commented Oct 24, 2020 •
edited
Loading

Codecov Report

Merging #13291 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13291   +/-   ##
=======================================
  Coverage   42.15%   42.15%           
=======================================
  Files         686      686           
  Lines       75625    75625           
=======================================
  Hits        31877    31877           
+ Misses      38522    38519    -3     
- Partials     5226     5229    +3
Impacted Files Coverage Δ
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/indexer/stats/db.go 52.17% <0.00%> (-8.70%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
modules/git/repo.go 46.19% <0.00%> (-0.51%) ⬇️
services/pull/pull.go 40.78% <0.00%> (-0.50%) ⬇️
services/pull/patch.go 55.68% <0.00%> (+1.70%) ⬆️
services/pull/check.go 51.82% <0.00%> (+2.91%) ⬆️
services/pull/temp_repo.go 29.78% <0.00%> (+3.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b91261c...2c77111. Read the comment docs.

@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit c5020cf into go-gitea:master Oct 24, 2020
@silverwind silverwind deleted the arcfixes3 branch October 25, 2020 08:19
ivanvc added a commit to ivanvc/gitea that referenced this pull request Oct 27, 2020
@ivanvc
Merge remote-tracking branch 'origin/master' into ensure-user-email-i…
e259244 
…s-stored-in-email-address-table

* origin/master:
  [UI] Hide consecutive additions and removals of the same label (go-gitea#13315)
  [skip ci] Updated translations via Crowdin
  Fix send mail (go-gitea#13312)
  [skip ci] Updated translations via Crowdin
  Deny wrong pull (go-gitea#13308)
  Group Label Changed Comments in timeline (go-gitea#13304)
  [skip ci] Updated translations via Crowdin
  Attempt to handle unready PR in tests (go-gitea#13305)
  go-gitea#12897 - add mastodon provider (go-gitea#13293)
  [skip ci] Updated translations via Crowdin
  Fix Storage mapping (go-gitea#13297)
  Update Mirror IsEmpty status on synchronize (go-gitea#13185)
  Fix bug isEnd detection on getIssues/getPullRequests (go-gitea#13299)
  systemd service: Add commented PATH environment option for Git prefix (go-gitea#13170)
  Sendmail command (go-gitea#13079)
  Various UI and arc-green fixes (go-gitea#13291)
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
7 participants
@silverwind @codecov-io @techknowlogick @lafriks @mrsdizzie @GiteaBot @zeripath