Skip to content

Show outdated comments in pull request (#13148) #13162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2020
Merged

Show outdated comments in pull request (#13148) #13162

merged 1 commit into from
Oct 16, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Oct 15, 2020

Backport of #13148

@ivanvc @zeripath @6543
Show outdated comments in pull request (go-gitea#13148)
c6b8a5c 
Co-authored-by: zeripath <art27@cantab.net>
@6543 6543 mentioned this pull request Oct 15, 2020
Merged
@6543 6543 added the type/enhancement An improvement of existing functionality label Oct 15, 2020
@zeripath
Copy link
Contributor

So one slight problem with this backport is that it will require the locales to be updated, otherwise LGTM.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 15, 2020
@zeripath zeripath added this to the 1.13.0 milestone Oct 15, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 16, 2020
@techknowlogick techknowlogick merged commit 2ec50b9 into go-gitea:release/v1.13 Oct 16, 2020
@6543 6543 deleted the backport_show-outdated-comments-in-pull-request_13148 branch October 16, 2020 01:52
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @zeripath @techknowlogick @GiteaBot @ivanvc