Skip to content

Conversation

eneuschild
Copy link
Contributor

@eneuschild eneuschild commented Oct 15, 2020

Hello again! :)

This is an attempt to address Issue #13090 .
Any feedback is greatly appreciated; I'm happy to learn.

@techknowlogick techknowlogick added the type/enhancement An improvement of existing functionality label Oct 15, 2020
@techknowlogick techknowlogick added this to the 1.14.0 milestone Oct 15, 2020
@codecov-io
Copy link

codecov-io commented Oct 15, 2020

Codecov Report

Merging #13160 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13160      +/-   ##
==========================================
+ Coverage   42.05%   42.06%   +0.01%     
==========================================
  Files         681      681              
  Lines       75121    75122       +1     
==========================================
+ Hits        31594    31603       +9     
+ Misses      38372    38368       -4     
+ Partials     5155     5151       -4     
Impacted Files Coverage Δ
models/org.go 73.80% <100.00%> (+0.05%) ⬆️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.54%) ⬇️
services/pull/pull.go 40.78% <0.00%> (ø)
models/error.go 34.39% <0.00%> (+0.50%) ⬆️
modules/git/repo.go 46.70% <0.00%> (+0.50%) ⬆️
modules/git/utils.go 77.04% <0.00%> (+3.27%) ⬆️
modules/indexer/stats/queue.go 76.47% <0.00%> (+11.76%) ⬆️
modules/indexer/stats/db.go 60.86% <0.00%> (+17.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8f7a6b...9c5a505. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 15, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 15, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 15, 2020
@techknowlogick techknowlogick merged commit 4fbe645 into go-gitea:master Oct 15, 2020
@lunny
Copy link
Member

lunny commented Oct 16, 2020

Why this is better than before? We may need options but not change it.

@lafriks
Copy link
Member

lafriks commented Oct 16, 2020

@lunny in combobox it does not make much sense to sort by last updated time from usability point of perspective imho

@eneuschild eneuschild deleted the sort_orgs_by_name branch October 16, 2020 11:17
ivanvc added a commit to ivanvc/gitea that referenced this pull request Oct 16, 2020
…ments-in-pull-request-label-style

* origin/master:
  [skip ci] Updated translations via Crowdin
  Fix diff skipping lines (go-gitea#13154)
  Update go-version v1.2.3 -> v1.2.4 (go-gitea#13169)
  Vendor Update Go Libs (go-gitea#13166)
  Prevent panics with missing storage (go-gitea#13164)
  Improve users management through the CLI (go-gitea#6001) (go-gitea#10492)
  Change order of possible-owner organizations to alphabetical (go-gitea#13160)
  Slightly simplify the queue settings code to help reduce the risk of problems (go-gitea#12976)
  [Vendor] Update go-ldap to v3.2.4 (go-gitea#13163)
  [skip ci] Updated translations via Crowdin
  Update external-renderers.en-us.md (go-gitea#13165)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants