Skip to content

[API] Add more filters to issues search #13514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 23, 2020
Merged

[API] Add more filters to issues search #13514

merged 7 commits into from
Nov 23, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 11, 2020 •
edited
Loading

  • Add time filter for issue search (since, before)
  • Add limit option for paggination
  • Add Filter for: Created by User, Assigned to User, Mentioning User

close #12461

@6543 6543 added modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality labels Nov 11, 2020
@6543 6543 added this to the 1.14.0 milestone Nov 11, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 12, 2020
@6543 6543 changed the title Api add some more filter to issues search [API] Add since, before, limit, assigned, created & mentioned filter to issues search Nov 14, 2020
@6543 6543 changed the title [API] Add since, before, limit, assigned, created & mentioned filter to issues search [API] Add more filters to issues search Nov 14, 2020
@6543 6543 mentioned this pull request Nov 14, 2020
Merged
@codecov-io
Copy link

codecov-io commented Nov 14, 2020 •
edited
Loading

Codecov Report

Merging #13514 (293482f) into master (b651409) will decrease coverage by 0.00%.
The diff coverage is 59.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13514      +/-   ##
==========================================
- Coverage   42.24%   42.23%   -0.01%     
==========================================
  Files         697      697              
  Lines       76576    76596      +20     
==========================================
+ Hits        32346    32350       +4     
- Misses      38914    38923       +9     
- Partials     5316     5323       +7
Impacted Files Coverage Δ
routers/api/v1/repo/issue.go 50.45% <50.00%> (-0.35%) ⬇️
models/issue.go 56.73% <100.00%> (+0.14%) ⬆️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️
services/pull/pull.go 40.78% <0.00%> (-0.50%) ⬇️
modules/queue/workerpool.go 60.81% <0.00%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b651409...293482f. Read the comment docs.

@6543 6543 force-pushed the api_add-filter-2-issues-search branch from d5ad7e6 to 293482f Compare November 21, 2020 11:12
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 23, 2020
@zeripath zeripath merged commit f88a2ea into go-gitea:master Nov 23, 2020
@6543 6543 deleted the api_add-filter-2-issues-search branch November 23, 2020 20:52
@jpraet jpraet mentioned this pull request Nov 25, 2020
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@zeripath zeripath zeripath approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @codecov-io @zeripath @a1012112796 @GiteaBot