Skip to content

API: Return error when Mirrors globaly disabled and like to create one #11757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2020
Merged

API: Return error when Mirrors globaly disabled and like to create one #11757

merged 2 commits into from
Jun 4, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Jun 4, 2020

@6543 6543 mentioned this pull request Jun 4, 2020
Merged
jolheiser
jolheiser reviewed Jun 4, 2020
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 4, 2020
@6543 @jolheiser
keep it consistent with UI
d284e61 
Co-authored-by: John Olheiser <john.olheiser@gmail.com>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 4, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 4, 2020
@techknowlogick techknowlogick added the modifies/api This PR adds API routes or modifies them label Jun 4, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Jun 4, 2020
@techknowlogick techknowlogick merged commit 0cb2212 into go-gitea:master Jun 4, 2020
@6543 6543 deleted the api-migrate-mirror-disabled-return-error branch June 4, 2020 16:17
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@6543 @jolheiser
API: Return error when Mirrors globaly disabled and like to create one (
f92edf7 
go-gitea#11757)

* API: return an error when Mirrors globaly disabled

* keep it consistent with UI

Co-authored-by: John Olheiser <john.olheiser@gmail.com>

Co-authored-by: John Olheiser <john.olheiser@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

+1 more reviewer

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @guillep2k @jolheiser @techknowlogick @GiteaBot