Skip to content

Update aria-fixed semantic-dropdown to fomantic master #10096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 2, 2020
Merged

Update aria-fixed semantic-dropdown to fomantic master #10096

merged 2 commits into from
Feb 2, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Feb 1, 2020

as per comments on #8638

@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label Feb 1, 2020
@zeripath zeripath added this to the 1.12.0 milestone Feb 1, 2020
@codecov-io
Copy link

codecov-io commented Feb 1, 2020 •
edited
Loading

Codecov Report

Merging #10096 into master will increase coverage by 0.03%.
The diff coverage is 60.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10096      +/-   ##
==========================================
+ Coverage   43.45%   43.49%   +0.03%     
==========================================
  Files         566      568       +2     
  Lines       78987    79113     +126     
==========================================
+ Hits        34324    34407      +83     
- Misses      40426    40459      +33     
- Partials     4237     4247      +10
Impacted Files Coverage Δ
modules/setting/setting.go 44.07% <0%> (-0.07%) ⬇️
cmd/embedded_stub.go 0% <0%> (ø)
routers/repo/branch.go 55.72% <100%> (+0.34%) ⬆️
modules/queue/manager.go 60.51% <100%> (ø) ⬆️
modules/repofiles/action.go 63.45% <100%> (-0.55%) ⬇️
routers/repo/view.go 40% <100%> (+0.52%) ⬆️
modules/repofiles/update.go 39.02% <42.2%> (-0.5%) ⬇️
routers/private/hook.go 36.43% <50%> (+0.42%) ⬆️
modules/setting/cache.go 53.84% <58.82%> (-19.49%) ⬇️
modules/git/commit_info.go 67.8% <63.63%> (-0.99%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8616a5...e787cc8. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 1, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 1, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 2, 2020
@techknowlogick techknowlogick merged commit b491424 into go-gitea:master Feb 2, 2020
@zeripath zeripath deleted the update-semantic-dropdown branch February 28, 2020 17:19
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
6 participants
@zeripath @codecov-io @lafriks @6543 @techknowlogick @GiteaBot