Implement basic global webhooks from config #10545
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10545 +/- ##
==========================================
+ Coverage 43.74% 43.77% +0.03%
==========================================
Files 586 586
Lines 81764 81789 +25
==========================================
+ Hits 35769 35807 +38
+ Misses 41553 41548 -5
+ Partials 4442 4434 -8
Continue to review full report at Codecov.
|
|
It would be better if they would be saved in database to have more flexibility and extendability in the future |
|
I agree to be honest. I'll take a look at it for another PR but it might not be perfect... |
bec5da6 to
b01478d
Compare
b01478d to
35f75c6
Compare
|
Closing in favour of #10546 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a very primitive way of having webhooks configured that work for all repositories across the system. Originally I misinterpreted
Default Webhooksas system-wide setting for this feature, and not just a template for new repositories - Doh 🤦♂The rationale for this change (as potentally hinted here) would be to enable more custom integrations. I was investigating at creating a custom authentication layer for a Docker registry, but wanted to know when a repository was deleted in order to remove images automatically. I was also looking at creating a utility to comment Jira tickets on PRs - equally in need of knowing events happening on the system.
I accept if this isn't a desired method, so alternatively we could look at implenting system webhooks in the UI and DB (while trying to avoid any confusion with default webhooks) or even a full 'apps/plugin API'? I'm also not that fluent at Go, so all comments are welcome! 😄