-
-
Notifications
You must be signed in to change notification settings - Fork 6k
Closed
Labels
issue/confirmedIssue has been reviewed and confirmed to be present or accepted to be implementedIssue has been reviewed and confirmed to be present or accepted to be implementedtype/bug
Milestone
Description
Description
I have a branch with a Branch Protection (at least 1 approval and a check that has to run)
The UI tells me I still can merge it anyway since i'm Admin. But when I try to merge it
The error message
This pull request is not ready to be merged, check review status and status checks.
Appears
Could also reproduce on try.gitea.io with [Powered by Gitea](https://gitea.io/) Version: 1.19.0+dev-521-g2b3f12f6f Page: 99ms Template: 11ms
Steps To Reproduce
- Be admin in repository
- Setup branch protection for any branch, require 1 approval
- Create a pull request pointing at the protected branch
- Try to merge without having 1 approval (with the red admin merge button)
Gitea Version
1.18.4
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
Git Version
No response
Operating System
No response
How are you running Gitea?
Irrelevant
Database
None
Metadata
Metadata
Assignees
Labels
issue/confirmedIssue has been reviewed and confirmed to be present or accepted to be implementedIssue has been reviewed and confirmed to be present or accepted to be implementedtype/bug