-
-
Notifications
You must be signed in to change notification settings - Fork 6k
Closed
Labels
issue/confirmedIssue has been reviewed and confirmed to be present or accepted to be implementedIssue has been reviewed and confirmed to be present or accepted to be implementedtopic/buildPR changes how Gitea is built, i.e. regarding Docker or the MakefilePR changes how Gitea is built, i.e. regarding Docker or the Makefile
Description
The models package dependency tree is rather complex. In particular it currently relies on and imports macaron.
This causes macaron's init to run even in gitea commands that will not run a webserver - it also prevents early mitigation of macaron's init.
We should move methods that require macaron out of models and in to routers or into modules and consider if there are other places in modules where we can avoid importing macaron.
sapk, lunny, mrsdizzie and rfwatsonrfwatson
Metadata
Metadata
Assignees
Labels
issue/confirmedIssue has been reviewed and confirmed to be present or accepted to be implementedIssue has been reviewed and confirmed to be present or accepted to be implementedtopic/buildPR changes how Gitea is built, i.e. regarding Docker or the MakefilePR changes how Gitea is built, i.e. regarding Docker or the Makefile