Skip to content

Mutualise a part of Context between net/http and gin #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 20, 2024
Merged

Mutualise a part of Context between net/http and gin #288

merged 3 commits into from
Dec 20, 2024

Conversation

EwenQuim
Copy link
Member

@EwenQuim EwenQuim commented Dec 19, 2024 •
edited
Loading

Tried to mutualize the Context so we will have less work to do for other integrations.

Base automatically changed from refactored-context to main December 19, 2024 22:17
@EwenQuim EwenQuim force-pushed the share-context-gin-nethttp branch from f7cd254 to a9b6a2f Compare December 19, 2024 22:24
@EwenQuim EwenQuim changed the title Mutualise some calls between net/http and gin Mutualise a part of Context between net/http and gin Dec 20, 2024
@EwenQuim EwenQuim marked this pull request as ready for review December 20, 2024 17:36
@EwenQuim EwenQuim requested a review from dylanhitt December 20, 2024 17:36
@EwenQuim EwenQuim mentioned this pull request Dec 20, 2024
Merged
dylanhitt
dylanhitt requested changes Dec 20, 2024
View reviewed changes
@EwenQuim EwenQuim merged commit 2991388 into main Dec 20, 2024
7 checks passed
@EwenQuim EwenQuim deleted the share-context-gin-nethttp branch December 20, 2024 18:22
@EwenQuim EwenQuim mentioned this pull request Dec 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanhitt dylanhitt dylanhitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EwenQuim @dylanhitt