Skip to content

checkers: fix commentedOutCode false positive #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2025
Merged

checkers: fix commentedOutCode false positive #1445

merged 2 commits into from
Mar 18, 2025

Conversation

alexandear
Copy link
Contributor

Fixes #1444

@alexandear alexandear force-pushed the checkers/commented-out-code-false-positive branch 2 times, most recently from 318c101 to c1c736e Compare November 20, 2024 11:19
@alexandear alexandear force-pushed the checkers/commented-out-code-false-positive branch from c1c736e to b259a0c Compare November 20, 2024 11:20
cristaloleg
cristaloleg approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@quasilyte
Copy link
Member

So the original issue was about it checking for Output string only in the first line?
The test should contain a case that would not be covered by the old code then.

@alexandear
Copy link
Contributor Author

So the original issue was about it checking for Output string only in the first line? The test should contain a case that would not be covered by the old code then.

Thank you for your feedback. Could you please clarify what specific change or test case you would like me to add? I want to make sure I fully understand and address the original issue.

@alexandear
Copy link
Contributor Author

@cristaloleg @quasilyte what steps should I do next to get this PR merged?

@cristaloleg
Copy link
Member

For me looks good, @quasilyte ?

@cristaloleg cristaloleg merged commit 65d90c1 into go-critic:master Mar 18, 2025
2 checks passed
@alexandear alexandear deleted the checkers/commented-out-code-false-positive branch March 18, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristaloleg cristaloleg cristaloleg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

commentedOutCode: false positive for the example output oneliner
3 participants
@alexandear @quasilyte @cristaloleg