checkers/exitAfterDefer: handle optional defer properly
#1437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will cause the check to stop looking if we are going into an Else block when we have found a deferStmt.
alexandear
approved these changes
Nov 8, 2024
|
Thank you @alexandear , let me know if there is anything else I can do with this PR before you merge it. |
|
@Afterous Unfortunately, I can't merge because I'm not a maintainer. |
|
Please edit PR's description with |
|
I added the string |
defer properly
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will correct a false positive reported in #1421
Let me know if there are any other alterations needed.
Thank you!
Fixes #1421