checkers/hugeParam: fix: ast.FuncDecl.Type.Results could be nil when checking for String() #1434
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This will fix a panic when you run go critic with hugeParam and scan a function that is named String, but does not return any value.
The document state the Results could be nil, this change will check for the nil before checking the length.
https://pkg.go.dev/go/ast#FuncType
Please let me know if you need me to write a test or fix anything else.
Thank you again for writing this tool!
example code that when ran with
./gocritic check -enable=hugeParam
will panic