Skip to content

checkers/hugeParam: ignore method String() string. #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2023
Merged

checkers/hugeParam: ignore method String() string. #1372

merged 1 commit into from
Sep 23, 2023

Conversation

lasiar
Copy link
Contributor

@lasiar lasiar commented Sep 23, 2023

Fixes #1168.

cristaloleg
cristaloleg approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@cristaloleg cristaloleg merged commit 7aea742 into go-critic:master Sep 23, 2023
@quasilyte
Copy link
Member

You folks are too fast. I can't even manage to read a notification in 1 hour while you go a whole road in this period of time. :D

@lasiar lasiar deleted the 1168-hugeParam-ignore-String branch September 23, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristaloleg cristaloleg cristaloleg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider ignoring some common methods in hugeParam checker
3 participants
@lasiar @quasilyte @cristaloleg