Skip to content

checkers/unlambda: correct calculation amount args. #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2023
Merged

checkers/unlambda: correct calculation amount args. #1377

merged 1 commit into from
Oct 10, 2023

Conversation

lasiar
Copy link
Contributor

@lasiar lasiar commented Oct 10, 2023

Count args of CallExpr.

Example: a(b(1,2)) will be 2, not 1.

fixes #1362

cristaloleg
cristaloleg approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 little comment, LGTM and thanks!

@lasiar
checkers/unlambda: correct calculation amount args.
c01302c 
Count args of CallExpr.

Example: `a(b(1,2))` will be 2, not 1.

fixes go-critic#1362
@cristaloleg cristaloleg merged commit c9950fa into go-critic:master Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristaloleg cristaloleg cristaloleg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unlambda: false positive
2 participants
@lasiar @cristaloleg