checker: add badSyncOnceFunc #1366
Merged
+84
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristaloleg
commented
Sep 4, 2023
checkers/rules/rules.go
Outdated
| //doc:after fooOnce := sync.OnceFunc(foo); ...; fooOnce() | ||
| func badSyncOnceFunc(m dsl.Matcher) { | ||
| m.Match(`$*_; sync.OnceFunc($x); $*_;`). | ||
| Suggest("sync.OnceFunc($x)()"). |
There was a problem hiding this comment.
Here I'm proposing to just invoke the result and after that match below will say "hey, it's still wrong".
cristaloleg
commented
Sep 4, 2023
| Where(m.GoVersion().GreaterEqThan("1.21")) | ||
|
|
||
| m.Match(`sync.OnceFunc($x)()`). | ||
| Report("possible sync.OnceFunc misuse, consider to assign sync.OnceFunc($x) to a variable"). |
There was a problem hiding this comment.
Probably this message can be better (and shorter). Better ideas?
quasilyte
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got bitten today.
Covers 2 cases:
sync.OnceFuncresult is invoked in-place (can be called many times)sync.OnceFuncresult isn't assigned to a variable (effectively no-op)