checkers: add new checker stringsCompare #1195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quasilyte
reviewed
Jan 16, 2022
quasilyte
reviewed
Jan 16, 2022
quasilyte
reviewed
Jan 16, 2022
|
I would do this in 2 steps:
|
|
@cristaloleg, what do you think? |
quasilyte
reviewed
Jan 22, 2022
quasilyte
requested changes
Jan 23, 2022
There was a problem hiding this comment.
Please, cover all cases with tests.
I don't see -1 value case.
Whether possible, all corner cases should be tested.
It's also a good practice to have "fixed" code examples in the negative tests suite.
For example, if linter suggests > operator, negative tests suite should contain the suggested code snippet, to be sure that this replacements does not trigger any other warning.
quasilyte
approved these changes
Jan 24, 2022
|
LGTM. |
quasilyte
approved these changes
Feb 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr for: #1167