Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Aug 2, 2021

No description provided.

cristaloleg
cristaloleg previously approved these changes Aug 2, 2021
Copy link
Member

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@quasilyte
Copy link
Member

Negative tests are tests without warnings; negative - no triggers.
Positive tests are tests with warnings; positive - have triggers.
The naming choice could be confusing, but this is why we can give a piece of advice here, on a review. :)

Also, I would like to see a negative test where WriteRune is called on a type that doesn't implement byte writer.

@cristaloleg cristaloleg merged commit fef2017 into go-critic:master Aug 6, 2021
@ghost ghost deleted the feature/prefer-write-byte branch August 27, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants