-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Add support for TinyGo #978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
Can someone help me test this with TinyGo?
I'll wait for few more reviews and we can merge 👍
build as expected, no error. BTW:
error output:
@efraimbart Maybe we also need to exclude |
Unfortunately I'm not familiar with middleware or what would happen if it's excluded. |
No worry, I can create other PR to fix the middleware build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/go-chi/chi/v5](https://github.com/go-chi/chi) | require | patch | `v5.2.1` -> `v5.2.2` | --- ### Release Notes <details> <summary>go-chi/chi (github.com/go-chi/chi/v5)</summary> ### [`v5.2.2`](https://github.com/go-chi/chi/releases/tag/v5.2.2) [Compare Source](go-chi/chi@v5.2.1...v5.2.2) #### What's Changed - Use strings.Cut in a few places by [@​JRaspass](https://github.com/JRaspass) in go-chi/chi#971 - Fix non-constant format strings in t.Fatalf by [@​JRaspass](https://github.com/JRaspass) in go-chi/chi#972 - Apply fieldalignment fixes to optimize struct memory layout by [@​pixel365](https://github.com/pixel365) in go-chi/chi#974 - go 1.24 by [@​pkieltyka](https://github.com/pkieltyka) in go-chi/chi#977 - chore: delint ioutil usage by [@​costela](https://github.com/costela) in go-chi/chi#962 - Fixed typo in Router interface definition by [@​mithileshgupta12](https://github.com/mithileshgupta12) in go-chi/chi#958 - Add support for TinyGo by [@​efraimbart](https://github.com/efraimbart) in go-chi/chi#978 - Exclude middleware/profiler.go in TinyGo, as there's no net/http/pprof pkg by [@​cxjava](https://github.com/cxjava) in go-chi/chi#982 - Make use of strings.Cut by [@​scop](https://github.com/scop) in go-chi/chi#1005 - Change install command format to code block by [@​sglkc](https://github.com/sglkc) in go-chi/chi#1001 - Correct documentation by [@​mrdomino](https://github.com/mrdomino) in go-chi/chi#992 #### Security fix - Fixes [GHSA-vrw8-fxc6-2r93](GHSA-vrw8-fxc6-2r93) - "Host Header Injection Leads to Open Redirect in RedirectSlashes" [commit](go-chi/chi@1be7ad9) - a lower-severity Open Redirect that can't be exploited in browser or email client, as it requires manipulation of a Host header - reported by Anuraag Baishya, [@​anuraagbaishya](https://github.com/anuraagbaishya). Thank you! #### New Contributors - [@​pixel365](https://github.com/pixel365) made their first contribution in go-chi/chi#974 - [@​mithileshgupta12](https://github.com/mithileshgupta12) made their first contribution in go-chi/chi#958 - [@​efraimbart](https://github.com/efraimbart) made their first contribution in go-chi/chi#978 - [@​cxjava](https://github.com/cxjava) made their first contribution in go-chi/chi#982 - [@​sglkc](https://github.com/sglkc) made their first contribution in go-chi/chi#1001 - [@​mrdomino](https://github.com/mrdomino) made their first contribution in go-chi/chi#992 **Full Changelog**: go-chi/chi@v5.2.1...v5.2.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC41Ny4xIiwidXBkYXRlZEluVmVyIjoiNDAuNTcuMSIsInRhcmdldEJyYW5jaCI6ImZvcmdlam8iLCJsYWJlbHMiOlsiZGVwZW5kZW5jeS11cGdyYWRlIiwidGVzdC9ub3QtbmVlZGVkIl19--> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8248 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org> Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [github.com/go-chi/chi/v5](https://github.com/go-chi/chi) | `v5.2.0` -> `v5.2.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- >⚠️ **Warning** > > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>go-chi/chi (github.com/go-chi/chi/v5)</summary> ### [`v5.2.2`](https://github.com/go-chi/chi/releases/tag/v5.2.2) [Compare Source](go-chi/chi@v5.2.1...v5.2.2) #### What's Changed - Use strings.Cut in a few places by [@​JRaspass](https://github.com/JRaspass) in go-chi/chi#971 - Fix non-constant format strings in t.Fatalf by [@​JRaspass](https://github.com/JRaspass) in go-chi/chi#972 - Apply fieldalignment fixes to optimize struct memory layout by [@​pixel365](https://github.com/pixel365) in go-chi/chi#974 - go 1.24 by [@​pkieltyka](https://github.com/pkieltyka) in go-chi/chi#977 - chore: delint ioutil usage by [@​costela](https://github.com/costela) in go-chi/chi#962 - Fixed typo in Router interface definition by [@​mithileshgupta12](https://github.com/mithileshgupta12) in go-chi/chi#958 - Add support for TinyGo by [@​efraimbart](https://github.com/efraimbart) in go-chi/chi#978 - Exclude middleware/profiler.go in TinyGo, as there's no net/http/pprof pkg by [@​cxjava](https://github.com/cxjava) in go-chi/chi#982 - Make use of strings.Cut by [@​scop](https://github.com/scop) in go-chi/chi#1005 - Change install command format to code block by [@​sglkc](https://github.com/sglkc) in go-chi/chi#1001 - Correct documentation by [@​mrdomino](https://github.com/mrdomino) in go-chi/chi#992 #### Security fix - Fixes [GHSA-vrw8-fxc6-2r93](GHSA-vrw8-fxc6-2r93) - "Host Header Injection Leads to Open Redirect in RedirectSlashes" [commit](go-chi/chi@1be7ad9) - a lower-severity Open Redirect that can't be exploited in browser or email client, as it requires manipulation of a Host header - reported by Anuraag Baishya, [@​anuraagbaishya](https://github.com/anuraagbaishya). Thank you! #### New Contributors - [@​pixel365](https://github.com/pixel365) made their first contribution in go-chi/chi#974 - [@​mithileshgupta12](https://github.com/mithileshgupta12) made their first contribution in go-chi/chi#958 - [@​efraimbart](https://github.com/efraimbart) made their first contribution in go-chi/chi#978 - [@​cxjava](https://github.com/cxjava) made their first contribution in go-chi/chi#982 - [@​sglkc](https://github.com/sglkc) made their first contribution in go-chi/chi#1001 - [@​mrdomino](https://github.com/mrdomino) made their first contribution in go-chi/chi#992 **Full Changelog**: go-chi/chi@v5.2.1...v5.2.2 ### [`v5.2.1`](https://github.com/go-chi/chi/releases/tag/v5.2.1) [Compare Source](go-chi/chi@v5.2.0...v5.2.1) ####⚠️ Chi supports Go 1.20+ Starting this release, we will now support the four most recent major versions of Go. See go-chi/chi#963 for related discussion. #### What's Changed - Support the four most recent major versions of Go by [@​VojtechVitek](https://github.com/VojtechVitek) in go-chi/chi#969 **Full Changelog**: go-chi/chi@v5.2.0...v5.2.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS41MS4xIiwidXBkYXRlZEluVmVyIjoiNDEuNTEuMSIsInRhcmdldEJyYW5jaCI6InYxMS4wL2Zvcmdlam8iLCJsYWJlbHMiOlsiZGVwZW5kZW5jeS11cGdyYWRlIiwidGVzdC9ub3QtbmVlZGVkIl19--> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8814 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org> Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Resolves #951