feat: update HTTP method parsing in patterns for Handle and HandleFunc
#900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @angelofallars! Thanks for this improvement which will be very much appreciated. Once merged, have you any idea when we can expect to have it shipped on a new release? Thanks again, and have a great day! |
|
thanks @angelofallars |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #899
Makes the
Mux.HandleFuncmethod also support patterns that include an HTTP method. This is the behavior consistent with Go 1.22'snet/http.ServeMux. Previously, onlyMux.Handlesupported HTTP method patterns according to #897 .Mux.HandleFunccallMux.Methodwhen a method pattern is detected.Mux.Handleto callMux.Methodinstead. Error handling for unrecognized HTTP methods is still kept this way.TestMuxHandlePatternValidationto also testMux.HandleFunc.