This repository was archived by the owner on Feb 16, 2022. It is now read-only.
Add support for custom sms gateway #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 22, 2021
|
@alexkappa could you review? What is the impact to current users that have Twilio configured? |
Revert change to continue matching style.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adding support for custom sms gateway as described in alexkappa/terraform-provider-auth0 #416, and implemented in alexkappa/terraform-provider-auth0 #417. This PR makes the following changes:
TwilioSID,TwilioToken, andMessagingServiceSID(they need to be omitted for custom gateway)Provider,GatewayUrl,GatewayAuthentication, andForwardRequestInfofields toConnectionOptionsSMSConnectionGatewayAuthenticationto support the custom authentication options for tokens sent to sms gatewayCommunity Note