fix: network icon functionality with proprietary vpn clients #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks for fixing this! Saw a couple others commenting on this in the Discord as well. Apologies for getting around to reviewing this so late. I've been working on and off on a major v3 version bump which has a bunch of changes, but it's finally good to go. I'll get this PR included in a beta release of v3 later today. |
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i updated the 3 examples/starter html files also to add the vpn icon functionality to the examples.
this addresses issue [Bug] Some VPNs cause NetworkIcon to be invalid #199 and potentially [Bug] Broken internet connection when using on windows hiddify in VPN mode #159.
i did not see any other additional errors or warnings after making these adjustments and confirmed that the other network icons are still functional.
this is my first PR ever, so feedback is welcomed. thank you to the team that created zebar and glazewm, they are both awesome!