Skip to content

feat: add focus --container-id <id> command #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 23, 2025
Merged

feat: add focus --container-id <id> command #963

merged 3 commits into from
Feb 23, 2025

Conversation

jsfr
Copy link
Contributor

@jsfr jsfr commented Feb 2, 2025 •
edited
Loading

This PR introduces a new command to focus a specific container by ID.

This allows to write scripts with the CLI to e.g. focus windows from a specific application.

@jsfr jsfr changed the title feat: add `focus_container_idAdd command to focus container by id feat: add focus_container_id command Feb 2, 2025
lars-berger
lars-berger requested changes Feb 7, 2025
View reviewed changes
@lars-berger
Copy link
Member

Thanks for the PR ❤️ Would def be useful to set specific focus, especially for IPC use cases.

There was a lint that just got added to clippy nightly which I've just put in a fix for (#967). If you sync with the main branch, the lint check flow should pass again 👍

Other than that LGTM

@jsfr jsfr requested a review from lars-berger February 9, 2025 19:29
@jsfr
Copy link
Contributor Author

jsfr commented Feb 21, 2025

@lars-berger I've addressed the comments :) Let me know if there's anything else missing.

@lars-berger lars-berger changed the title feat: add focus_container_id command feat: add focus --container-id <id> command Feb 23, 2025
@lars-berger lars-berger merged commit a5b7045 into glzr-io:main Feb 23, 2025
3 checks passed
@lars-berger
Copy link
Member

Perfect 🙌 thank you!

It's looking like the next release will be in 1.5-2 weeks. Doing a big Zebar feature and then I'll do a combined release of GlazeWM+Zebar with this PR included 👍

Miitto pushed a commit to Miitto/glazewm that referenced this pull request Jun 12, 2025
@jsfr @Miitto
feat: add focus --container-id <id> command (glzr-io#963)
1d9e983
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lars-berger lars-berger lars-berger approved these changes

Assignees
No one assigned
Labels
released
Projects
glazewm
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsfr @lars-berger