This causes some problems with the ShareX screenshot overlay. When you open it and move your cursor to another monitor it steals focus away from the overlay. This happens even tough the overlay spans all your monitors, and it should be detected by the window focusing code...

Maybe the Windows API function for finding windows overlapping a point doesn't really work, and we should instead make our own implementation? Or maybe we should add a command to always keep a window focused?

This causes some problems with the ShareX screenshot overlay. When you open it and move your cursor to another monitor it steals focus away from the overlay. This happens even tough the overlay spans all your monitors, and it should be detected by the window focusing code...

Maybe the Windows API function for finding windows overlapping a point doesn't really work, and we should instead make our own implementation? Or maybe we should add a command to always keep a window focused?

Just did a lil testing and ShareX is causing issues because it's ignored by the WM. Since ignored windows aren't part of the WM's tree of windows that it manages, state.focused_container() will point to the last focused window/workspace that had focus prior to ShareX gaining focus. So it'll currently try to set focus away from ShareX when the cursor goes to a different monitor.

What I'd suggest is we add a new is_focus_synced field to WmState which represents whether OS focus is synced with whatever window/workspace the WM believes should have focus. We can then update this field by adding to L26 of handle_window_focused.rs (also refactor L98-101 of the same file):

  state.is_focus_synced = match focused_container.as_window_container() {
    Ok(window) => *window.native() == *native_window,
    _ => Platform::desktop_window() == *native_window,
  };

We could then return early in handle_mouse_move.rs L16 if !state.is_focus_synced. So we'd essentially pause focus_follows_mouse if an ignored window has focus.

80b01dc has some problems right now when moving the mouse between monitors and windows. I think the is_focus_synced field isn't being set to true in all the cases it should be. I will look into it.

80b01dc has some problems right now when moving the mouse between monitors and windows. I think the is_focus_synced field isn't being set to true in all the cases it should be. I will look into it.

Put in a small fix commit for this just now - could you check if it's fully working on your end? Did some quick testing and it all seems to be behaving nicely now

It seems to be working now, thanks for fixing! And sorry for taking so long to reply… You can merge it now.

🎉 This PR is included in version 3.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

🎉 This PR is included in version 3.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀