Skip to content

fix: pause IPC event not emitting #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2025
Merged

fix: pause IPC event not emitting #889

merged 1 commit into from
Jan 10, 2025

Conversation

michidk
Copy link
Contributor

@michidk michidk commented Dec 16, 2024

Fixes the pause IPC not working:

PS Microsoft.PowerShell.Core\FileSystem::\\wsl.localhost\Arch\home\michi\dev\glazewm\target\x86_64-pc-windows-gnu\debug> ./glazewm sub -e pause_changed
{"data":{"eventType":"pause_changed","isPaused":false},"error":null,"subscriptionId":"bf8e2089-487a-4cc9-8846-f5c9e7b17b82","success":true}
{"data":{"eventType":"pause_changed","isPaused":false},"error":null,"subscriptionId":"bf8e2089-487a-4cc9-8846-f5c9e7b17b82","success":true}
{"data":{"eventType":"pause_changed","isPaused":false},"error":null,"subscriptionId":"bf8e2089-487a-4cc9-8846-f5c9e7b17b82","success":true}

@michidk michidk mentioned this pull request Dec 16, 2024
Merged
@reeseponsive
Copy link

Hi, does this fix how the pause doesn't work in #882?

@michidk
Copy link
Contributor Author

michidk commented Dec 30, 2024

Im not too familiar with how keybindings work, but we don't unregister them in pause mode. So this fix won't solve that.
I think the best way to do that would be a shortcut which kills glazewm and starts it again instead of pausing.

I totally see you usecase. But it assumes that the other application tries to register it's hotkeys during app start (so it would need to be started when glazewm is paused), but when unpausing glazewm probably will not be able to register the hotkey again (unless all other apps which might register them are closed).

@lars-berger lars-berger changed the title fix: pause IPC not working fix: pause IPC event not emitting Jan 10, 2025
@lars-berger lars-berger merged commit 5199f62 into glzr-io:main Jan 10, 2025
2 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
glazewm
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michidk @reeseponsive @lars-berger