Skip to content

feat: revert to keybindings for prev/next active workspace in sample config #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 30, 2024
Merged

feat: revert to keybindings for prev/next active workspace in sample config #865

merged 2 commits into from
Nov 30, 2024

Conversation

DreamMaoMao
Copy link
Contributor

@DreamMaoMao DreamMaoMao commented Nov 27, 2024 •
edited
Loading

Notice many people asking how this key is bound, and it is a common feature, so suggest adding them to the default sample configuration

@lars-berger
Copy link
Member

Ah I overlooked that the sample config still uses --next-workspace and --prev-workspace after PR #783. Even though both commands are useful, switching between active workspaces is likely the more common use case.

Since they're such similar commands, I don't think it's worth adding both to the sample config and I'd suggest we instead change alt+a and alt+s to use --prev-active-workspace and --next-active-workspace instead.

@DreamMaoMao
Copy link
Contributor Author

Ah I overlooked that the sample config still uses --next-workspace and --prev-workspace after PR #783. Even though both commands are useful, switching between active workspaces is likely the more common use case.

Since they're such similar commands, I don't think it's worth adding both to the sample config and I'd suggest we instead change alt+a and alt+s to use --prev-active-workspace and --next-active-workspace instead.

makes sense. It's been replaced.

@lars-berger lars-berger changed the title docs: add --next-active-workspace and --prev-active-workspace opt… feat: revert to keybindings for prev/next active workspace in sample config Nov 30, 2024
@lars-berger lars-berger merged commit feae1f4 into glzr-io:main Nov 30, 2024
2 checks passed
@DreamMaoMao DreamMaoMao deleted the docs-optimize-sample-config branch December 1, 2024 10:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

🎉 This PR is included in version 3.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
glazewm
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DreamMaoMao @lars-berger