Skip to content

Conversation

DreamMaoMao
Copy link
Contributor

  - commands: ['toggle-floating --centered']
    bindings: ['alt+\']

if use --centered option in toggle-flating. it will be set position of the flaoting window to centered at first time.

2024-11-09.12-10-39.mp4

@lars-berger
Copy link
Member

Hey @DreamMaoMao - I hope you don't mind but did a couple of tweaks: 1) check has_custom_floating_placement for set-floating so that it's consistent with toggle-floating 2) remove has_custom_floating_placement from the DTO (this gets emitted via our public IPC interface, and I think it's probs best if we just use it internally).

Thanks for the huge help on this🙏 Will go ahead and merge!

@lars-berger lars-berger changed the title feat: auto set position centered at first time in toggle-floating com… feat: improve --centered flag behavior for set-floating and toggle-floating Dec 2, 2024
@lars-berger lars-berger merged commit 47ef45c into glzr-io:main Dec 2, 2024
1 check passed
Copy link

github-actions bot commented Dec 3, 2024

🎉 This PR is included in version 3.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@DreamMaoMao DreamMaoMao deleted the feat-auto-centered-first-time branch December 5, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants