Sort megacli devices numerically #191
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
one of our Supermicro servers has 36 local disks attached to a MegaRaid controller. megacli sorts the disks by enclosure id and slot number, but check_raid displays the device id instead. This may lead to unsorted output:
The attached patch sorts the devices numerically:
Which makes it much easier to spot the missing disk id 30.
I tried to put the sort function into join_status() first, but that did not work as not all controllers return disk names that are easily sortable (01 vs. 1:2 vs. Y2O483PAS).
Regards,
Christopher