mdstat: Check if a certain amount of spares are present #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you add some tests to the new code paths? |
|
I have added some test data and some tests. What do you think on this PR? Any chance to get this included? |
|
looks like my previous comment was never posted the tests pass, so looks good. ideally i'd not make the methods even longer, but use subroutines. but the cleanup can be done later as well. |
|
I wonder how would users find the options/features like this? Do you mind writing some pod documentation to specific plugin header? this would be first plugin having such doc, so you can be creative ;) |
|
you can grab new version from snapshot build
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a plugin option to check if a certain amount of spares in an md array are present:
Example:
check_raid --plugin-option=mdstat_spare_count="md126:3,md127:2"
checks that md126 has at least 3 spares and that md127 has at least 2 spares