Skip to content

Conversation

Fusion
Copy link
Collaborator

@Fusion Fusion commented Sep 9, 2023

Thank you for making a pull request!

A few things to be aware of as you're working on your PR:

WIP Tag

Incomplete PRs are more than welcome - it can be useful to collaborate before
implementation of an idea is complete. However, if your PR is not ready
for merge, please add [WIP] to the end of the title (work-in-progress).

Tests

Before committing, you are encouraged to run the small but growing test
suite. This is accomplished by make test. Additionally, if you are adding
new functionality, consider adding tests covering your feature.

CI

Each push to a branch connected to a PR will be run through GLAuth's
CI system. Please use these to your advantage. In particular, the Github Actions
integration tests rely on the LDAP queries returning with a set result,
so if your changes will change the output, CI will likely fail.

To update, run make fast && make updatetest && make test. This will
delete the output snapshots provided and make new ones. You can then
inspect the changes and commit them.

Similarly, check codeclimate and try to fix what you find there if it fails.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ghost
Copy link

ghost commented Sep 9, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Fusion Fusion merged commit 08a89a9 into dev Sep 9, 2023
@Fusion Fusion deleted the feature/robustness-sum-types branch October 8, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant