Update go.work to 1.19 #315
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Merged
Fusion
added a commit
that referenced
this pull request
Jul 4, 2023
Cross-platform changes: - No SysLog on Windows (#289) Code quality: - CodeSee integration - Add CodeQL workflow for GitHub code scanning (#295) Correctness: - Construct DNs under ou=users for uniqueMember group attribute - Use NameFormat/GroupFormat when constructing RDN attributes - Brian Candler (@candlerb) completed the above by making sure they were supported where it matters - The directory structure can be navigated up and down using any LDAP browser - searchMaybePosixAccounts: add filter to respect searchBaseDN (#304) - Feature: introduce legacy behavior, based on past versions (#318) Security/Updates: - Bump golang.org/x/crypto in /v2 - Update Go Versions to 1.19, 1.20 (#314) - Added anonymousdse backend option to config sample (#316) Qualify of life: - Add devcontainer (#306) - Add help command to Makefile (#307) - Update go.work to 1.19 (#315)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had never gotten around to your comment about Go version in #306 , fixing now.
Based on my read of #314 , 1.19 is the most appropriate value for this file.
make testdockerandmake test(aftermake fast) worked from inside a Devcontainer so I think all looks good.