Skip to content

Fix build with Boost 1.77.0 #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2022
Merged

Fix build with Boost 1.77.0 #263

merged 1 commit into from
Aug 17, 2022

Conversation

PiRK
Copy link
Collaborator

@PiRK PiRK commented Aug 16, 2022

This is a backport of https://reviews.bitcoinabc.org/D10769

It is needed to run ninja check with boost 1.77.

The error I'm getting without this is:

/home/p/dev/lotusd/src/wallet/test/init_test_fixture.cpp: In constructor ‘InitWalletDirTestingSetup::InitWalletDirTestingSetup(const string&)’:
/home/p/dev/lotusd/src/wallet/test/init_test_fixture.cpp:37:52: error: ‘std::map<std::__cxx11::basic_string<char>, boost::filesystem::path>::mapped_type’ {aka ‘class boost::filesystem::path’} has no member named ‘BOOST_FILESYSTEM_C_STR’
   37 |     std::ofstream f(m_walletdir_path_cases["file"].BOOST_FILESYSTEM_C_STR);
      |                                                    ^~~~~~~~~~~~~~~~~~~~~~

@sizeofvoid @PiRK
Fix build with Boost 1.77.0
c12bafc 
Summary:
BOOST_FILESYSTEM_C_STR changed to accept the path as an argument

This is a backport of [[bitcoin/bitcoin#22713 | core#22713]]

Test Plan: `ninja all check-all`

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10769
@schancel schancel merged commit 0c207a7 into givelotus:master Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schancel schancel schancel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PiRK @schancel @sizeofvoid